mirror of
https://github.com/deunix-educ/aventuriers-des-mots.git
synced 2026-10-13 02:11:58 +02:00
Add pure correction and pedagogy logic with full test coverage
scripts/correction/: AnswerValidator (multiple choice, sentence correction via tap-the-faulty-word + retype) and DictationAnalyzer build the CorrectionResult structure from cahier des charges §6. Dictation analysis aligns words with WordAligner (Wagner-Fischer edit distance) before any character comparison, so an omitted or added word doesn't cascade into false errors on every following word. TextNormalizer handles non-breaking spaces, typographic apostrophes, and decomposed-vs-composed French accented characters via an explicit table (GDScript has no built-in NFC/NFD normalization). Error classification follows the data annotations only (rule_id present -> grammatical, absent -> unclassified), never a runtime linguistic guess. scripts/pedagogy/: DifficultyManager (per-skill difficulty from recent results), AttemptFlow (3-attempt graduated aid: hint, then explanation, then reveal, matching exercise-lifecycle.md's second gap), and ReviewScheduler (the five mastery states from §9, with session-counted spaced review intervals [1, 3, 6, 12] rather than wall-clock dates, since a family device's clock isn't trustworthy). All of it is pure: no scene tree, no clock or RNG read directly, every effectful input (session number, attempt outcome) is a parameter. 65 headless tests across both layers, including the word-omission-doesn't-cascade regression and the full decouverte -> acquise -> a_reviser -> acquise path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,128 @@
|
||||
class_name DictationAnalyzer
|
||||
extends RefCounted
|
||||
## Analyse la production ecrite d'un enfant pour une dictee : alignement mot a
|
||||
## mot (WordAligner) avant comparaison, normalisation (TextNormalizer), puis
|
||||
## classification de chaque erreur via les annotations de la donnee cible
|
||||
## (dictation["words"]). Sans annotation (pas de rule_id), l'erreur reste non
|
||||
## classee (voir "Points durs" du prompt de lancement). Code pur, sans horloge
|
||||
## ni hasard. L'explication complete (texte de la regle) est composee par la
|
||||
## couche d'affichage a partir des rule_id retournes, pas ici.
|
||||
|
||||
|
||||
static func analyze(dictation: Dictionary, submitted_text: String) -> CorrectionResult:
|
||||
var normalized_submitted := TextNormalizer.normalize(submitted_text)
|
||||
var normalized_target := TextNormalizer.normalize(dictation["target_text"])
|
||||
|
||||
if _matches_target_or_variant(dictation, normalized_submitted, normalized_target):
|
||||
return CorrectionResult.correct(_build_explanation(0))
|
||||
|
||||
var target_words := TextNormalizer.split_words(normalized_target)
|
||||
var submitted_words := TextNormalizer.split_words(normalized_submitted)
|
||||
var words_meta: Array = dictation["words"]
|
||||
|
||||
# L'alignement se fait insensible a la casse : une majuscule manquante est
|
||||
# une erreur de capitalisation a part, pas un mot substitue (voir
|
||||
# docs/specs/decisions.md point 6).
|
||||
var target_words_for_align := _to_lower_all(target_words)
|
||||
var submitted_words_for_align := _to_lower_all(submitted_words)
|
||||
var ops := WordAligner.align(target_words_for_align, submitted_words_for_align)
|
||||
var errors: Array[Dictionary] = []
|
||||
|
||||
for op: Dictionary in ops:
|
||||
match op["op"]:
|
||||
"match":
|
||||
var capital_error: Variant = _check_capitalization(
|
||||
words_meta, op["target_index"], submitted_words[op["submitted_index"]]
|
||||
)
|
||||
if capital_error != null:
|
||||
errors.append(capital_error)
|
||||
"substitute":
|
||||
(
|
||||
errors
|
||||
. append(
|
||||
_classify_error(
|
||||
words_meta,
|
||||
op["target_index"],
|
||||
submitted_words[op["submitted_index"]],
|
||||
)
|
||||
)
|
||||
)
|
||||
"delete":
|
||||
errors.append(_classify_error(words_meta, op["target_index"], ""))
|
||||
"insert":
|
||||
(
|
||||
errors
|
||||
. append(
|
||||
{
|
||||
"position": target_words.size(),
|
||||
"error_type": "unclassified",
|
||||
"rule_id": "",
|
||||
"found": submitted_words[op["submitted_index"]],
|
||||
"expected": "",
|
||||
}
|
||||
)
|
||||
)
|
||||
|
||||
if errors.is_empty():
|
||||
return CorrectionResult.correct(_build_explanation(0))
|
||||
|
||||
return CorrectionResult.incorrect(
|
||||
errors, _build_explanation(errors.size()), "", [dictation["target_text"]]
|
||||
)
|
||||
|
||||
|
||||
static func _matches_target_or_variant(
|
||||
dictation: Dictionary, normalized_submitted: String, normalized_target: String
|
||||
) -> bool:
|
||||
if normalized_submitted == normalized_target:
|
||||
return true
|
||||
for variant: String in dictation.get("accepted_variants", []):
|
||||
if normalized_submitted == TextNormalizer.normalize(variant):
|
||||
return true
|
||||
return false
|
||||
|
||||
|
||||
static func _classify_error(words_meta: Array, target_index: int, found: String) -> Dictionary:
|
||||
var meta: Dictionary = words_meta[target_index] if target_index < words_meta.size() else {}
|
||||
var expected: String = meta.get("text", "")
|
||||
var rule_id: String = meta.get("rule_id", "")
|
||||
return {
|
||||
"position": target_index,
|
||||
"error_type": "grammatical" if not rule_id.is_empty() else "unclassified",
|
||||
"rule_id": rule_id,
|
||||
"found": found,
|
||||
"expected": expected,
|
||||
}
|
||||
|
||||
|
||||
static func _check_capitalization(
|
||||
words_meta: Array, target_index: int, submitted_word: String
|
||||
) -> Variant:
|
||||
if target_index >= words_meta.size() or submitted_word.is_empty():
|
||||
return null
|
||||
var meta: Dictionary = words_meta[target_index]
|
||||
if not meta.get("expects_capital", false):
|
||||
return null
|
||||
var first_letter := submitted_word.substr(0, 1)
|
||||
if first_letter == first_letter.to_upper():
|
||||
return null
|
||||
return {
|
||||
"position": target_index,
|
||||
"error_type": "capitalization",
|
||||
"rule_id": meta.get("rule_id", ""),
|
||||
"found": submitted_word,
|
||||
"expected": meta.get("text", submitted_word),
|
||||
}
|
||||
|
||||
|
||||
static func _to_lower_all(words: Array[String]) -> Array[String]:
|
||||
var result: Array[String] = []
|
||||
for word in words:
|
||||
result.append(word.to_lower())
|
||||
return result
|
||||
|
||||
|
||||
static func _build_explanation(error_count: int) -> String:
|
||||
if error_count == 0:
|
||||
return "Dictee correcte."
|
||||
return "Dictee corrigee : %d erreur(s) a revoir." % error_count
|
||||
Reference in New Issue
Block a user